Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/#review199744 --- src/Makefile.am Line 2301 (original)

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/ --- (Updated March 21, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-21 Thread Benjamin Bannier
> On March 20, 2018, 4:55 p.m., Benjamin Bannier wrote: > > include/csi/spec.hpp > > Lines 23 (patched) > > > > > > Not really related to this particular patch, but referencing this > > somewhat internal define in a

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-20 Thread Chun-Hung Hsiao
> On March 20, 2018, 3:55 p.m., Benjamin Bannier wrote: > > include/csi/spec.hpp > > Lines 23 (patched) > > > > > > Not really related to this particular patch, but referencing this > > somewhat internal define in a

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/ --- (Updated March 20, 2018, 11:44 p.m.) Review request for mesos, Benjamin

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/#review199546 --- Fix it, then Ship it! include/csi/spec.hpp Lines 23 (patched)