Re: Review Request 66671: Updated composing containerizer tests.

2018-05-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review203738 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 11:23

Re: Review Request 66671: Updated composing containerizer tests.

2018-05-23 Thread Andrei Budnik
> On May 22, 2018, 9:26 a.m., Qian Zhang wrote: > > For the tests `DestroyDuringUnsupportedLaunchLoop` and > > `DestroyAfterLaunchLoop`, I think the intention of both of them is to check > > the value of `container->destroyed` set in > > `ComposingContainerizerProcess::_launch()`. But in your

Re: Review Request 66671: Updated composing containerizer tests.

2018-05-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review203555 --- For the tests `DestroyDuringUnsupportedLaunchLoop` and

Re: Review Request 66671: Updated composing containerizer tests. (WIP)

2018-04-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201382 --- Patch looks great! Reviews applied: [8, 9, 66670, 66671]

Re: Review Request 66671: Updated composing containerizer tests. (WIP)

2018-04-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review201327 --- PASS: Mesos patch 66671 was successfully built and tested.