Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/ --- (Updated May 9, 2018, 7:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/#review202739 --- Fix it, then Ship it! configure.ac Lines 2071 (patched)

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/ --- (Updated May 9, 2018, 12:50 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-08 Thread Chun-Hung Hsiao
> On May 8, 2018, 9:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am > > Line 182 (original), 185 (patched) > > > > > > It is not clear to me that this would always find the correct > > libraries. I see e.g.,

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-08 Thread Chun-Hung Hsiao
> On May 8, 2018, 9:33 a.m., Benjamin Bannier wrote: > > 3rdparty/Makefile.am > > Lines 326 (patched) > > > > > > This variable name makes sense only 50% of the time, how about e.g., > > `GRPC_LIB_SUFFIX`? I'll

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

2018-05-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/#review202621 --- 3rdparty/Makefile.am Lines 326 (patched)