Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68203/ --- (Updated Aug. 7, 2018, 10:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-06 Thread Qian Zhang
> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 318 (patched) > > > > > > I'd suggest we separate this patch, and have one patch for each > >

Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-06 Thread Qian Zhang
> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 318 (patched) > > > > > > I'd suggest we separate this patch, and have one patch for each > >

Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-04 Thread Jie Yu
> On Aug. 5, 2018, 5:46 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 318 (patched) > > > > > > I'd suggest we separate this patch, and have one patch for each > >

Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68203/#review206864 --- src/slave/containerizer/mesos/isolators/volume/host_path.cpp

Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68203/ --- (Updated Aug. 4, 2018, 5:58 p.m.) Review request for mesos, Gilbert Song, Greg