Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 16, 2018, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 15, 2018, 3:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207365 --- Fix it, then Ship it! src/slave/flags.cpp Lines 356-362

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207359 --- Fix it, then Ship it! docs/configuration/agent.md Lines

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 15, 2018, 11:49 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 14, 2018, 5:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207234 --- Patch looks great! Reviews applied: [68304, 68324] Passed

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207212 --- PASS: Mesos patch 68324 was successfully built and tested.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-13 Thread Meng Zhu
> On Aug. 13, 2018, 4:14 p.m., Benjamin Mahler wrote: > > src/slave/flags.cpp > > Lines 365-380 (patched) > > > > > > Maybe we should start these with `authentication`? How about: > > > > ``` > >

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-13 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 13, 2018, 10:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207208 --- Patch looks great! Reviews applied: [68304, 68324] Passed

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207182 --- PASS: Mesos patch 68324 was successfully built and tested.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

2018-08-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207178 --- src/slave/flags.cpp Lines 365-380 (patched)