Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208810 --- Fix it, then Ship it! src/v1/resources.cpp Lines 1657-1675

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 11, 2018, 7:25 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Line 1641 (original), 1655 (patched) > > > > > > Actually, I was thinking about this, isn't the casting to `Resource` > >

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 14, 2018, 3:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208538 --- Almost there! I'm wondering about the casting to `Resource` in

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 6, 2018, 8:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 6, 2018, 3:27 a.m., Benjamin Bannier wrote: > > include/mesos/resources.hpp > > Line 588 (original), 590 (patched) > > > > > > `s/Resource/Resource_/`? `Resource_` is not exposed outside, it is

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 6, 2018, 10:27 a.m., Benjamin Bannier wrote: > > src/v1/resources.cpp > > Lines 2117-2118 (original), 2154-2178 (patched) > > > > > > This function looks redundant and identical to `Resources::add(const

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 6, 2018, 2:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208402 --- include/mesos/resources.hpp Line 588 (original), 590 (patched)

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 2:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 2:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 4, 2018, 2:36 a.m., Benjamin Bannier wrote: > > Have you benchmarked against a dedicated copy-on-write abstraction? I > > understand that the current implementation which only copies when needed > > might be more performant, but it also appears to carry a huge mental > > overhead

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 3, 2018, 9:59 p.m., Benjamin Mahler wrote: > > Thanks! Can you also include some commentary on the rest of the allocation > > benchmarks as well as the overhead within the Resources micro-benchmarks? Posted the updated patches. Will summarize and post more comprehensive results

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 12:17 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208295 --- Have you benchmarked against a dedicated copy-on-write

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208286 --- Thanks! Can you also include some commentary on the rest of the