Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 22, 2018, 9:21 p.m.) Review request for mesos, Andrew

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209716 --- Ship it! LGTM. I filed

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 17, 2018, 8:29 p.m.) Review request for mesos, Andrew

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 17, 2018, 9:52 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 128-130 (original), 139-141 (patched) > > > > > > This comment is still incorrect, especially with

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 17, 2018, 9:52 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/fsync.hpp > > Lines 53-55 (patched) > > > > > > Related to the discussion from > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209689 --- 3rdparty/stout/include/stout/os/posix/fsync.hpp Lines 53-55

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 16, 2018, 2:45 a.m.) Review request for mesos, Andrew

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 128-130 (original), 138-140 (patched) > > > > > > Not yours and not affecting the `sync=true` case, but

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 133-134 (patched) > > > > > > Is the performance impact in the comment common knowledge? I would have >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/rename.hpp > > Lines 41 (patched) > > > > > > While POSIX guarantees that `rename` e.g., does not see inconsistent > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/rename.hpp > > Lines 41 (patched) > > > > > > While POSIX guarantees that `rename` e.g., does not see inconsistent > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/rename.hpp > > Lines 41 (patched) > > > > > > While POSIX guarantees that `rename` e.g., does not see inconsistent > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 133-134 (patched) > > > > > > Is the performance impact in the comment common knowledge? I would have >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 4:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/rename.hpp > > Lines 41 (patched) > > > > > > While POSIX guarantees that `rename` e.g., does not see inconsistent > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/rename.hpp > > Lines 41 (patched) > > > > > > While POSIX guarantees that `rename` e.g., does not see inconsistent > >

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209538 --- 3rdparty/stout/include/stout/os/posix/rename.hpp Lines 41

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209509 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 12, 2018,

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 12, 2018, 11:53 p.m.) Review request for mesos, Andrew