Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Nov. 17, 2018, 12:49 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69086: Moved container root construction to the isolators.

> On Nov. 5, 2018, 5:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 623-631 (patched) > > > > > > I don't think this is needed. `prepareMount` in launch.cpp will

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Nov. 9, 2018, 12:53 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69086: Moved container root construction to the isolators.

> On Nov. 3, 2018, 6:49 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 146 (patched) > > > > > > This mount fails with user namespaces: > > ``` > > Failed

Re: Review Request 69086: Moved container root construction to the isolators.

> On Nov. 5, 2018, 5:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 73-80 (patched) > > > > > > I would prefer simply use `ContainerMountInfo`, instead of

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/#review210318 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/#review210313 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Oct. 30, 2018, 9:03 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69086: Moved container root construction to the isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/ --- (Updated Oct. 29, 2018, 11:59 p.m.) Review request for mesos, Gilbert Song,