Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215855 --- Ship it! Refactor looks good. One minor tweak to consider

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 10, 2019, 9:49 a.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215710 --- Patch looks great! Reviews applied: [70783] Passed command:

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 4:13 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215701 --- 3rdparty/libprocess/src/metrics/metrics.cpp Lines 212-226

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

> On June 5, 2019, 1:05 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp > > Lines 199-207 (patched) > > > > > > If we consolidate the logging between user timeout and slow timeout can >

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 3:39 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

> On June 4, 2019, 8:42 p.m., Joseph Wu wrote: > > I think it is a little unfortunate that we end up with a conditional > > `select()` and an extra chaining step in this endpoint. But since we > > aren't saving the vector of keys/futures/statistics anywhere, the chaining > > is mostly

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 3:37 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215693 --- Looks good, but I'm also wondering if there's a cleaner way to

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215689 --- I think it is a little unfortunate that we end up with a