Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-19 Thread Qian Zhang
> On March 19, 2020, 11:15 a.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 1177 (patched) > > > > > > Could you move this to the end of the test so we're just paused for the

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219993 --- Fix it, then Ship it!

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219992 --- src/tests/containerizer/cgroups_isolator_tests.cpp Line 1173

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 18, 2020, 10:54 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219979 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 900-902

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 18, 2020, 10:01 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 17, 2020, 3:02 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 16, 2020, 9:52 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 16, 2020, 5:15 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 7, 2020, 5:02 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219804 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 716

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219276 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884,

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-01-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219238 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884,

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-01-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated Jan. 13, 2020, 4:06 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-01-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219225 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,