---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/
---
(Updated June 17, 2015, 5:06 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review88085
---
src/hook/manager.cpp (lines 96 - 98)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review88088
---
Ship it!
Ship It!
- Niklas Nielsen
On June 15, 2015, 3:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/
---
(Updated June 15, 2015, 5:22 p.m.)
Review request for mesos, Niklas Nielsen
On June 3, 2015, 1:17 p.m., Niklas Nielsen wrote:
src/hook/manager.cpp, line 95
https://reviews.apache.org/r/30339/diff/3/?file=975940#file975940line95
Don't you need to acquire the mutex here?
Good catch. Fixed.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/
---
(Updated June 15, 2015, 6:26 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review87991
---
Patch looks great!
Reviews applied: [30339]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review86574
---
src/hook/manager.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/
---
(Updated June 1, 2015, 5:26 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/
---
(Updated June 1, 2015, 5:46 p.m.)
Review request for mesos, Niklas Nielsen and
On June 1, 2015, 5:41 p.m., Niklas Nielsen wrote:
Do you have a JIRA ticket for this change?
Is it to avoid memory copies, that you need these to be in the call sites.
It clutters the call sites a bit, so I wanted to seee if we could move this
into the HooksManager instead.
11 matches
Mail list logo