Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-17 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 17, 2015, 5:06 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review88085 --- src/hook/manager.cpp (lines 96 - 98)

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review88088 --- Ship it! Ship It! - Niklas Nielsen On June 15, 2015, 3:26 p.m.,

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 15, 2015, 5:22 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
On June 3, 2015, 1:17 p.m., Niklas Nielsen wrote: src/hook/manager.cpp, line 95 https://reviews.apache.org/r/30339/diff/3/?file=975940#file975940line95 Don't you need to acquire the mutex here? Good catch. Fixed. - Kapil

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 15, 2015, 6:26 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review87991 --- Patch looks great! Reviews applied: [30339] All tests passed. -

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86574 --- src/hook/manager.cpp

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 1, 2015, 5:26 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ --- (Updated June 1, 2015, 5:46 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
On June 1, 2015, 5:41 p.m., Niklas Nielsen wrote: Do you have a JIRA ticket for this change? Is it to avoid memory copies, that you need these to be in the call sites. It clutters the call sites a bit, so I wanted to seee if we could move this into the HooksManager instead.