On June 2, 2015, 12:57 a.m., Chi Zhang wrote:
Cong, is this the patch the requires code from 3.2.26 for the first time?
If so, should we add a compile-time flag to config.ac? That way Paul can
safely back off the code for the stat string conversion from the other
patch you commented
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated June 1, 2015, 10:45 p.m.)
Review request for mesos, Chi Zhang, Ian
On June 2, 2015, 12:57 a.m., Chi Zhang wrote:
Cong, is this the patch the requires code from 3.2.26 for the first time?
If so, should we add a compile-time flag to config.ac? That way Paul can
safely back off the code for the stat string conversion from the other
patch you commented
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review86155
---
Ship it!
I added the slave flag for you.
Please follow up with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review86133
---
Cong, is this the patch the requires code from 3.2.26 for the first
On May 22, 2015, 10:09 p.m., Jie Yu wrote:
Two high level comments:
1) We need a slave flag to control if turning on this feature or not
2) Do you think we should at least add some unit test for this? For
example, verify that the filters are properly set up?
Jie Yu wrote:
On May 22, 2015, 10:09 p.m., Jie Yu wrote:
Two high level comments:
1) We need a slave flag to control if turning on this feature or not
2) Do you think we should at least add some unit test for this? For
example, verify that the filters are properly set up?
Jie Yu wrote:
On May 22, 2015, 10:09 p.m., Jie Yu wrote:
Two high level comments:
1) We need a slave flag to control if turning on this feature or not
2) Do you think we should at least add some unit test for this? For
example, verify that the filters are properly set up?
Jie Yu wrote:
On May 22, 2015, 10:09 p.m., Jie Yu wrote:
Two high level comments:
1) We need a slave flag to control if turning on this feature or not
2) Do you think we should at least add some unit test for this? For
example, verify that the filters are properly set up?
Ping. Did you see these
On May 22, 2015, 10:09 p.m., Jie Yu wrote:
Two high level comments:
1) We need a slave flag to control if turning on this feature or not
2) Do you think we should at least add some unit test for this? For
example, verify that the filters are properly set up?
Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated May 26, 2015, 8:41 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review85268
---
src/slave/containerizer/isolators/network/port_mapping.cpp
On May 26, 2015, 9:54 p.m., Chi Zhang wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1843-1850
https://reviews.apache.org/r/31505/diff/8/?file=972152#file972152line1843
this could also happen if we are recovering a container not using this
feature right?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review84998
---
Two high level comments:
1) We need a slave flag to control if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated May 17, 2015, 12:27 a.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review83690
---
src/slave/containerizer/isolators/network/port_mapping.hpp
On May 14, 2015, 7:44 p.m., Jie Yu wrote:
src/slave/containerizer/isolators/network/port_mapping.hpp, line 329
https://reviews.apache.org/r/31505/diff/5/?file=955871#file955871line329
Please add some comments about what this is. Consider using hashset
instead of std::set.
We
On May 14, 2015, 7:44 p.m., Jie Yu wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, line 1767
https://reviews.apache.org/r/31505/diff/5/?file=955872#file955872line1767
No need to use `filter::` prefix for `filter::Filter` as it's already
included.
Without it I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated May 12, 2015, 12:14 a.m.)
Review request for mesos, Chi Zhang, Ian
19 matches
Mail list logo
