Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-08-24 Thread Niklas Nielsen
On June 15, 2015, 12:07 p.m., Niklas Nielsen wrote: Hey Robert; BenH helped out and wrote a PoC patch here https://reviews.apache.org/r/35405 In short; it is not safe to delete the detector at this point. The patch above does it in join() and has a good descriptive block of comment

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33208/#review87958 --- Hey Robert; BenH helped out and wrote a PoC patch here

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-12 Thread Benjamin Hindman
On April 20, 2015, 5:55 a.m., Adam B wrote: LGTM, barring a question about ordering/synchronization. I'll let another committer take a look before we commit it. Adam B wrote: Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-11 Thread Niklas Nielsen
On April 19, 2015, 10:55 p.m., Adam B wrote: LGTM, barring a question about ordering/synchronization. I'll let another committer take a look before we commit it. Adam B wrote: Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-01 Thread Niklas Nielsen
On April 19, 2015, 10:55 p.m., Adam B wrote: LGTM, barring a question about ordering/synchronization. I'll let another committer take a look before we commit it. Adam B wrote: Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be