Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-06-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review85943 --- Patch looks great! Reviews applied: [33792] All tests passed. -

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated June 1, 2015, 4:17 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review84457 --- Ship it! Ship It! - Alexander Rojas On May 20, 2015, 4:06 a.m.,

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 20, 2015, 2:06 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 12, 2015, 12:50 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 12, 2015, 12:54 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 12, 2015, 12:55 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review83303 --- Thanks! Could you split the patch between the implementation and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:24 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:36 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:04 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:13 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
On May 4, 2015, 6:46 p.m., Alexander Rojas wrote: I am not really sure this is the way to go in order to create a case insensite hashmap. The class `hashmap` simply adds functionality to the `boost::unordered_map`. If one checks the API for the latter, the way needed to create an

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:23 p.m.) Review request for mesos, Alexander Rojas and