Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review84222 --- Ship it! Ship It! - Benjamin Hindman On May 17, 2015, 10:11

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
On May 16, 2015, 8:50 p.m., Joris Van Remoortere wrote: src/log/network.hpp, lines 434-440 https://reviews.apache.org/r/34018/diff/2/?file=954649#file954649line434 It looks like we missed a nice example for this in the style guide! (the lambda not being the first function

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review84061 --- Patch looks great! Reviews applied: [34017, 34018] All tests

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review84042 --- Hey Haosdent, These look great. Just 1 suggestion for cleaning up

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review83163 --- Patch looks great! Reviews applied: [34017, 34018] All tests

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/ --- (Updated May 9, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman