Re: Review Request 34129: Add 2 optional args advertise_ip and advertise_port for libprocess to advertise.

2015-08-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review95257 --- Can this be merged now unless there are more comments? Also needs

Re: Review Request 34129: Add 2 optional args advertise_ip and advertise_port for libprocess to advertise.

2015-08-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review95287 --- Ship it! Ship It! - Vinod Kone On July 30, 2015, 10:36 p.m.,

Re: Review Request 34129: Add 2 optional args advertise_ip and advertise_port for libprocess to advertise.

2015-07-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review93678 --- Patch looks great! Reviews applied: [34128, 34129] All tests

Re: Review Request 34129: Add 2 optional args advertise_ip and advertise_port for libprocess to advertise.

2015-07-30 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/ --- (Updated July 30, 2015, 10:36 p.m.) Review request for mesos and Cosmin