Re: Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-06-01 Thread Ben Mahler
On May 19, 2015, 6:53 p.m., Ben Mahler wrote: Looks like we need to add a step for resolving the JIRA ticket (including the commit message in a comment), if applicable? Jie Yu wrote: Will add that later. Not sure if it belongs to this file, or we need to have a new doc regarding

Re: Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-05-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34420/#review84724 --- Ship it! Ship It! - Niklas Nielsen On May 19, 2015, 10:40 a.m.,

Re: Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-05-21 Thread Jie Yu
On May 19, 2015, 6:53 p.m., Ben Mahler wrote: Looks like we need to add a step for resolving the JIRA ticket (including the commit message in a comment), if applicable? Will add that later. Not sure if it belongs to this file, or we need to have a new doc regarding the pratices we used

Re: Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-05-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34420/#review84363 --- Looks like we need to add a step for resolving the JIRA ticket

Re: Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-05-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34420/#review84393 --- Patch looks great! Reviews applied: [34420] All tests passed. -

Review Request 34420: Updated the committer doc regarding checking JIRA before committing.

2015-05-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34420/ --- Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.