Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Chi Zhang
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/fq_codel.cpp, line 102 https://reviews.apache.org/r/34830/diff/2/?file=975051#file975051line102 ignore if you have done in a different patch: egress::ROOT? (You had ingress::ROOT) feel free to drop

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Jie Yu
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/ingress.hpp, lines 55-56 https://reviews.apache.org/r/34830/diff/2/?file=975052#file975052line55 a bit confused by an ingress qdisc on the egress side of the link I saw this in other places too. +1

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Isabel Jimenez
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/ingress.cpp, lines 44-51 https://reviews.apache.org/r/34830/diff/2/?file=975053#file975053line44 Two blank lines between the functions. here and other places. Since the functions are inside a

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/fq_codel.cpp, line 102 https://reviews.apache.org/r/34830/diff/2/?file=975051#file975051line102 ignore if you have done in a different patch: egress::ROOT? (You had ingress::ROOT) Chi Zhang

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86029 --- src/linux/routing/queueing/fq_codel.cpp

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86006 --- src/linux/routing/queueing/fq_codel.cpp

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated June 1, 2015, 7:49 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated June 2, 2015, 12:23 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-05-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review85828 --- Ship it! src/linux/routing/queueing/fq_codel.hpp

Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-05-29 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: