Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/ --- (Updated June 24, 2015, 10:01 p.m.) Review request for mesos and Till

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-24 Thread Benjamin Hindman
On June 23, 2015, 12:35 a.m., Till Toenshoff wrote: src/tests/containerizer.cpp, lines 127-128 https://reviews.apache.org/r/35567/diff/2/?file=988913#file988913line127 Cant follow this one - are you saying that `executorEnvironment(..)` should possibly set environment variables?

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-24 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review89271 --- src/tests/slave_tests.cpp (lines 2109 - 2110)

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review88780 --- Ship it! src/slave/flags.cpp (line 28)

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review88669 --- Bad patch! Reviews applied: [35561, 35562, 35563, 35564] Failed