Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 14, 2015, 5:13 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 99 > > > > > > "/" -> "|" ? Turns out this is a review board display artifact. - Bernd

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review91606 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 45)

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review91116 --- Patch looks great! Reviews applied: [35998] All tests passed. - M

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 7, 2015, 9:50 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 48 > > > > > > It would be good to explain why we are opting this way. How is this > > useful? OK,

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/ --- (Updated July 9, 2015, 4:02 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 7, 2015, 2:50 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 48 > > > > > > It would be good to explain why we are opting this way. How is this > > useful? OK,

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 7, 2015, 9:50 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 24 > > > > > > I know that in many other places we have written "Basic abstraction", > > but this

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 7, 2015, 9:50 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 39 > > > > > > Do you mean std::basename()? Nope, the free C function `basename()` is part of the

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 1, 2015, 7:05 a.m., Joerg Schad wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 44 > > > > > > Did you check how this displays in the rendered version? Good point, looks horrible -

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review90677 --- 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 24)

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review90018 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review89735 --- Patch looks great! Reviews applied: [35998] All tests passed. - M

Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/ --- Review request for mesos, Bernd Mathiske and Joerg Schad. Repository: mesos D