Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-08 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 5:23 p.m.) Review request for mesos, Ian Downes, Jie

Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. Repository: mesos

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 12:03 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90819 --- docs/network-isolation.md (line 29)

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90828 --- Bad patch! Reviews applied: [36281] Failed command:

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90827 --- Thanks for writing this up! I had a few minor suggestions and some

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90798 --- docs/network-isolation.md (line 7)

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90813 --- Ship it! Thanks Paul! This is great! It's a little hard to review

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90858 --- Patch looks great! Reviews applied: [36281] All tests passed. -

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90857 --- Ship it! A few other minor nits, but I think we can commit this

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
On July 7, 2015, 11:31 p.m., Jie Yu wrote: docs/network-isolation.md, line 7 https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line7 Please do not delete the version information. Network monitoring is added in mesos 0.20 and network isolation is added in mesos

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
On July 8, 2015, 12:01 a.m., Adam B wrote: docs/network-isolation.md, line 79 https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line79 Why is this a fixed constant limit? Seems like we might want to adjust this depending on how many containers are running, or

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 12:59 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Adam B
On July 7, 2015, 5:01 p.m., Adam B wrote: docs/network-isolation.md, line 79 https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line79 Why is this a fixed constant limit? Seems like we might want to adjust this depending on how many containers are running, or give