---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 24, 2015, 9:57 a.m.)
Review request for mesos.
Bugs:
On July 20, 2015, 4:42 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 297
https://reviews.apache.org/r/36501/diff/6/?file=1015170#file1015170line297
According
On July 20, 2015, 4:42 p.m., haosdent huang wrote:
haosdent huang wrote:
Its a bit difficult to follow the mesos style guide at first. Maybe the
committer could help you reformat it when summit @klausma1982 . :-)
Thanks very much for your patience; yes, it tooks time for me to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92889
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
On July 24, 2015, 2:01 p.m., Klaus Ma wrote:
If you don't get to them first, I will fix the remaining little style
suggestions when committing.
OK, please help to fix it. I'll learn it from the final code :). Thanks very
much.
- Klaus
On July 20, 2015, 9:42 a.m., haosdent huang wrote:
haosdent huang wrote:
Its a bit difficult to follow the mesos style guide at first. Maybe the
committer could help you reformat it when summit @klausma1982 . :-)
Klaus Ma wrote:
Thanks very much for your patience; yes, it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92911
---
Ship it!
src/tests/fetcher_tests.cpp (line 295)
On July 20, 2015, 9:42 a.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 297
https://reviews.apache.org/r/36501/diff/6/?file=1015170#file1015170line297
According
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
---
src/tests/fetcher_tests.cpp (line 297)
On July 20, 2015, 4:42 p.m., haosdent huang wrote:
Its a bit difficult to follow the mesos style guide at first. Maybe the
committer could help you reformat it when summit @klausma1982 . :-)
- haosdent
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 18, 2015, 9:47 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92170
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 17, 2015, 2:06 p.m.)
Review request for mesos.
Bugs:
On July 17, 2015, 7:13 a.m., haosdent huang wrote:
src/tests/utils.hpp, line 72
https://reviews.apache.org/r/36501/diff/3/?file=1013117#file1013117line72
How about check path length and use `path[0]` here? Instead of
`*(path.begin())`
I think we can use startsWith to check it.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92082
---
Ship it!
Ship It!
src/tests/fetcher_tests.cpp (line 22)
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
Ship It!
3rdparty/libprocess/src/tests/http_tests.cpp have a unit test case
TEST(URLTest, Stringification) show how to use URL and stringify it. Maybe
you could use URL according that.
- haosdent
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 22
https://reviews.apache.org/r/36501/diff/4/?file=1014441#file1014441line22
Need sort it lexicographically.
```
#include sstream
#include string
```
#include sstream
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92033
---
src/tests/utils.hpp (line 30)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92093
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 17, 2015, 4:13 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92104
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 22
https://reviews.apache.org/r/36501/diff/4/?file=1014441#file1014441line22
Need sort it lexicographically.
```
#include sstream
#include string
haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92108
---
src/tests/fetcher_tests.cpp (line 22)
On 七月 17, 2015, 5:39 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 66
https://reviews.apache.org/r/36501/diff/5/?file=1014595#file1014595line66
Because use stringify, could remove it now.
yes. agree. i'll update the code.
- Klaus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91871
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
On July 15, 2015, 4:16 a.m., haosdent huang wrote:
src/tests/utils.hpp, line 55
https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line55
The code styple need change to follow
https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md
I've read
On July 15, 2015, 4:16 a.m., haosdent huang wrote:
src/tests/utils.hpp, line 54
https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line54
I suggest move the implement to cpp file.
As far as I known, C++ can not declare template in header file and implete it
in cpp.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 16, 2015, 5:47 a.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 16, 2015, 4:41 a.m.)
Review request for mesos.
Bugs:
On July 15, 2015, 9:19 p.m., Joseph Wu wrote:
src/tests/utils.hpp, line 55
https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line55
* Tab size = 2 spaces.
* Parameters are indented by 4 spaces.
* Comments start with a capital letter and end with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91863
---
Patch looks great!
Reviews applied: [36501]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91732
---
src/tests/utils.hpp (line 26)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/
---
(Updated July 15, 2015, 2:59 a.m.)
Review request for mesos.
Bugs:
33 matches
Mail list logo
