Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review101316 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 2, 2015, 1:38

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review97972 --- Ship it! Ship It! - Qian Zhang On Sept. 2, 2015, 9:38 p.m.,

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Sept. 2, 2015, 1:38 p.m.) Review request for mesos, Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

> On Aug. 24, 2015, 9:12 p.m., Alexander Rukletsov wrote: > > include/mesos/master/quota.proto, line 19 > > > > > > I think we should version this protobuf. As so far only mesos and scheduler are versioned, we don't

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96906 --- include/mesos/master/quota.proto (line 38)

Re: Review Request 36908: Added QuotaInfo Protobuf.

On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: src/Makefile.am, line 182 https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182 It is better consider the alpha order of those files, we can add quota related files under module related files. Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: include/mesos/master/quota.proto, line 19 https://reviews.apache.org/r/36908/diff/4/?file=1032679#file1032679line19 Yes, does v1 API will be supportted for quota? Adding new protobufs should be backwards-compatible, so I suppose the

Re: Review Request 36908: Added QuotaInfo Protobuf.

On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote: src/Makefile.am, line 182 https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182 It is better consider the alpha order of those files, we can add quota related files under module related files. Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96482 --- src/Makefile.am (line 182)

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96299 --- include/mesos/master/quota.proto (line 19)

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Aug. 5, 2015, 2:03 p.m.) Review request for mesos, Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review94258 --- Patch looks great! Reviews applied: [36908] All tests passed. -

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review94014 --- Patch looks great! Reviews applied: [36908] All tests passed. -

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93909 --- Ship it! Looks good to me. src/Makefile.am (lines 182 - 183)

Re: Review Request 36908: Added QuotaInfo Protobuf.

On Aug. 3, 2015, 2:44 p.m., Bernd Mathiske wrote: include/mesos/master/quota.proto, line 38 https://reviews.apache.org/r/36908/diff/2/?file=1024652#file1024652line38 limit, bound - plural I would suggest to reword: Add upper bounds limit of resources that ... - Till

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93908 --- include/mesos/master/quota.proto (line 25)

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Aug. 3, 2015, 7:01 p.m.) Review request for mesos, Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated July 29, 2015, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93496 --- Patch looks great! Reviews applied: [36908] All tests passed. -

Re: Review Request 36908: Added QuotaInfo Protobuf.

On July 29, 2015, 12:21 p.m., Till Toenshoff wrote: src/Makefile.am, line 261 https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261 This line looks too long. Till Toenshoff wrote: Seems we actually tolerate this - feel free to drop this issue. I was

Re: Review Request 36908: Added QuotaInfo Protobuf.

On July 29, 2015, 12:21 p.m., Till Toenshoff wrote: src/Makefile.am, line 261 https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261 This line looks too long. Seems we actually tolerate this - feel free to drop this issue. - Till

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review93445 --- include/mesos/master/quota.hpp (lines 19 - 20)