Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96980 --- Ship it! Ship It! - Timothy Chen On Aug. 22, 2015, 5:04 p.m.,

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 29, 2015, 12:22 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96990 --- Patch looks great! Reviews applied: [37669] All tests passed. -

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 29, 2015, 12:02 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37669: Ignore overflow components in version parsing.

On Aug. 30, 2015, 1:47 a.m., Ben Mahler wrote: Is 1.7.0.fc22 legal semver? From what I can tell looking at http://semver.org/, it is not legal? (1) Could we also follow up with the docker folks to use legal semver versioning? (2) It would be nice if we could push the logic of the

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96878 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96113 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 22, 2015, 6:10 a.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96117 --- 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp (line

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96114 --- Ship it! Ship It! - Guangya Liu On 八月 22, 2015, 6:10 a.m.,

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96116 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 22, 2015, 5:04 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 37669: Ignore overflow components in version parsing.

On Aug. 22, 2015, 2:39 p.m., Kapil Arya wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 17 https://reviews.apache.org/r/37669/diff/3/?file=1047943#file1047943line17 Since we are using just `std::min`, can't we simple use an `if` or `?:` to avoid

Re: Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96112 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Review Request 37669: Ignore overflow components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- Review request for mesos, Isabel Jimenez and Timothy Chen. Bugs: MESOS-2986