Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-09-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review98366 --- Ship it! I've committed this for you with the following minor chang

Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-09-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review98363 --- Patch looks great! Reviews applied: [37968] All tests passed. - M

Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-09-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/ --- (Updated 九月 10, 2015, 2:38 a.m.) Review request for mesos and Michael Park. C

Re: Review Request 37968: Add more comments for why not using const reference for some functions

2015-08-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review97184 --- Patch looks great! Reviews applied: [37968] All tests passed. - M

Review Request 37968: Add more comments for why not using const reference for some functions

2015-08-31 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/ --- Review request for mesos and Michael Park. Bugs: MESOS-3344 https://issues.