Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 17, 2015, 12:14 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review99254 --- Have you surveyed how other libraires handle this? For example, the

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 16, 2015, 6:01 p.m., Ben Mahler wrote: > > Have you surveyed how other libraires handle this? For example, the scala > > play framework seems to use BigDecimal (128 bit floating point) for all > > numbers, which can represent all 64 bit signed / unsigned integral values > > without

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 16, 2015, 6:01 p.m., Ben Mahler wrote: > > Have you surveyed how other libraires handle this? For example, the scala > > play framework seems to use BigDecimal (128 bit floating point) for all > > numbers, which can represent all 64 bit signed / unsigned integral values > > without

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 16, 2015, 11:01 a.m., Ben Mahler wrote: > > Have you surveyed how other libraires handle this? For example, the scala > > play framework seems to use BigDecimal (128 bit floating point) for all > > numbers, which can represent all 64 bit signed / unsigned integral values > >

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 16, 2015, 6:01 p.m., Ben Mahler wrote: > > Have you surveyed how other libraires handle this? For example, the scala > > play framework seems to use BigDecimal (128 bit floating point) for all > > numbers, which can represent all 64 bit signed / unsigned integral values > > without

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 15, 2015, 8:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 128 > > > > > > Haha! Perhaps the most subtle C++11 feature. > > Joseph Wu wrote: > You

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review99058 --- Ship it! Ship It! - Michael Park On Sept. 15, 2015, 5:24 p.m.,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98998 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 15, 2015, 1:41 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 128 > > > > > > Haha! Perhaps the most subtle C++11 feature. You mean the comma at the end?

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 15, 2015, 10:24 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 14, 2015, 1:37 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review97421 --- For some reason this did not get posted when it should have.

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98910 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98901 --- Ship it!

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98906 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 11, 2015, 10:42 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 10, 2015, 11:25 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 9, 2015, 3:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

> On Sept. 9, 2015, 3:24 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 103-110 > > > > > > Let's make this overlapped storage private and add accessors. We