Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review100721 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:43 a.m., Al

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99757 --- Ship it! Ship It! - Marco Massenzio On Sept. 21, 2015, 2:43 a.m.

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 21, 2015, 2:43 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Marco Massenzio
> On Sept. 17, 2015, 4:44 p.m., Marco Massenzio wrote: > > I'm excited about this! > > Tested on OSX and (at least, as far as stout_tests go, it works, yay!) > > > > A quick question: why, instead of moving the files, we don't simply add a > > symlink that will "look right" to the linker etc. >

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99692 --- Patch looks great! Reviews applied: [38456, 38457] All tests passe

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 20, 2015, 2:03 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 20, 2015, 1:25 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
> On Sept. 18, 2015, 9:10 p.m., Joseph Wu wrote: > > You should consider adding a CMake macro to make this more maintainable. > > > > A macro that does something like: > > ``` > > mkdir -p ${INPUT_SRC}-lib/lib > > && cp -r ${INPUT_SRC}-build/lib/.libs/. ${INPUT_SRC}-lib/lib > > ``` I actually

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
> On Sept. 17, 2015, 4:44 p.m., Marco Massenzio wrote: > > I'm excited about this! > > Tested on OSX and (at least, as far as stout_tests go, it works, yay!) > > > > A quick question: why, instead of moving the files, we don't simply add a > > symlink that will "look right" to the linker etc. >

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99599 --- You should consider adding a CMake macro to make this more maintaina

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99401 --- I'm excited about this! Tested on OSX and (at least, as far as stout

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99378 --- Patch looks great! Reviews applied: [38456, 38457] All tests passe

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 17, 2015, 10:03 a.m.) Review request for mesos, Artem Harutyunya