Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Anand Mazumdar
> On Sept. 23, 2015, 7:02 p.m., Felix Abecassis wrote: > > Bad timing, this breaks the build because of > > https://reviews.apache.org/r/38517/ Ahh bummer, `make check` succeeded for me too may be it because it was able to find the header `common/attributes.hpp` in the build folder. Fixing it.

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100264 --- Bad timing, this breaks the build because of https://reviews.apache

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- (Updated Sept. 23, 2015, 6:13 p.m.) Review request for mesos, Isabel Jimenez an

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100250 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 4:16 p.m., An

Re: Review Request 38630: Fixed order for header includes

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100013 --- Patch looks great! Reviews applied: [38630] All tests passed. -

Review Request 38630: Fixed order for header includes

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos De