Re: Review Request 39060: Create master detector per url & not per framework.

2016-01-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review116314 --- Ship it! src/sched/sched.cpp (line 167)

Re: Review Request 39060: Create master detector per url & not per framework

2016-01-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review112792 --- Bad patch! Reviews applied: [39060] Failed command:

Re: Review Request 39060: Create master detector per url & not per framework.

2016-01-05 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Jan. 5, 2016, 9:01 a.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2016-01-05 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Jan. 5, 2016, 8:48 a.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2016-01-04 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Jan. 5, 2016, 3:17 a.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-11-03 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Nov. 3, 2015, 9:32 a.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-11-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review104895 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39060: Create master detector per url & not per framework

2015-11-03 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Nov. 3, 2015, 6:06 p.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-11-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review104966 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-21 Thread Mandeep Chadha
> On Oct. 21, 2015, 12:41 a.m., Joris Van Remoortere wrote: > > Hey Mandeep, Thanks for taking on this important work! > > Some high level questions: > > - Do we need to do reference counting manually or can we use a construct > > like `Shared` in Libprocess that wraps the `std::shared_ptr`. >

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review103331 --- Hey Mandeep, Thanks for taking on this important work! Some high

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101874 --- src/sched/sched.cpp (line 157)

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-08 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 8, 2015, 5:05 p.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-07 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 7, 2015, 9:42 p.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-07 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 7, 2015, 9:49 p.m.) Review request for mesos and Joris Van

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101847 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101738 --- src/sched/sched.cpp (line 139)

Review Request 39060: Create master detector per url & not per framework

2015-10-06 Thread Mandeep Chadha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- Review request for mesos. Bugs: MESOS-3595

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101704 --- Bad review! Reviews applied: [] Error: No reviewers specified.