Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review103020 --- Thanks for adding this! Are you looking to also work on docker

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102836 --- Patch looks great! Reviews applied: [39353] All tests passed. -

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102839 --- Ship it! Ship It! - Gilbert Song On Oct. 15, 2015, 12:17 p.m.,

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Ben Mahler
> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 51 > > > > > > Would this also allow @@ or @@@ ? Wondering if we can use a regular > > expression

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102816 --- src/slave/containerizer/provisioner/docker/message.hpp (line 46)

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Ben Mahler
> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 46 > > > > > > How about handling parse errors ? Maybe change this to a Try? Agreed, did you see

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Jojy Varghese
> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 46 > > > > > > How about handling parse errors ? Maybe change this to a Try? > > Ben Mahler wrote:

Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/ --- Review request for mesos, Jojy Varghese and Timothy Chen. Repository: mesos