Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote: > > Can you also sync this with the V1 API? (If so, I'll remove that section > > from this: https://reviews.apache.org/r/39502 ). > > Connor Doyle wrote: > Yes, I will update the v1 proto file as well. Thanks for the reminder. Updated.

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103611 --- Bad patch! Reviews applied: [39531] Failed command:

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103607 --- Bad patch! Reviews applied: [39531] Failed command:

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103650 --- include/mesos/mesos.proto (lines 1395 - 1409)

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 11:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-180 > > > > > > Dumb question -- could we have used `JSON::Protobuf()` instead? Hey Kapil, I'll try it out. - Connor

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 11:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-180 > > > > > > Dumb question -- could we have used `JSON::Protobuf()` instead? > > Connor Doyle wrote: > Hey Kapil, I'll try

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 22, 2015, 5:08 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-22 Thread Connor Doyle
> On Oct. 22, 2015, 12:45 a.m., Joseph Wu wrote: > > Can you also sync this with the V1 API? (If so, I'll remove that section > > from this: https://reviews.apache.org/r/39502 ). Yes, I will update the v1 proto file as well. Thanks for the reminder. - Connor

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103506 --- Bad patch! Reviews applied: [39531] Failed command:

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103497 --- Can you also sync this with the V1 API? (If so, I'll remove that

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103496 --- Should we also mention it explicitly that each NetworkInfo message