Re: Review Request 39848: Validate revocable resources

> On 一月 19, 2016, 1:31 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, lines 1485-1524 > > > > > > +1 to Vinod's comment on 'validation.cpp'. > > > > Another suggestion which doesn't require a large re

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review115154 --- src/slave/slave.cpp (lines 1485 - 1524)

Re: Review Request 39848: Validate revocable resources

> On 十二月 5, 2015, 12:21 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1503 > > > > > > I think at this point it's worthwhile to factor out the validations in > > this function into slave/validation.cpp file

Re: Review Request 39848: Validate revocable resources

> On 十二月 5, 2015, 12:21 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1503 > > > > > > I think at this point it's worthwhile to factor out the validations in > > this function into slave/validation.cpp file

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review109063 --- src/slave/slave.cpp (line 1503)

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review105226 --- Patch looks great! Reviews applied: [39845, 39848] All tests pass

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/ --- (Updated 十一月 5, 2015, 7:36 a.m.) Review request for mesos and Vinod Kone. Bug

Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2647 https://issues.ap