Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/#review105230 --- Patch looks great! Reviews applied: [39944, 39945] All tests pass

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/ --- (Updated Nov. 5, 2015, 8:25 a.m.) Review request for mesos, Ben Mahler, Jojy Va

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread haosdent huang
> On Nov. 4, 2015, 6:25 p.m., Jojy Varghese wrote: > > src/slave/containerizer/containerizer.cpp, line 259 > > > > > > Wondering if we can pass in a prefix set to the os::environment. This > > way, we get LIBPROCESS

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/ --- (Updated Nov. 5, 2015, 3:19 a.m.) Review request for mesos, Ben Mahler, Jojy Va

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/#review105111 --- src/slave/containerizer/containerizer.cpp (line 259)

Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39945/ --- Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. Reposito