Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review141517 --- Closing this review due to inactivity. Please see our

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2016-01-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review112741 --- Ship it! Ship It! - haosdent huang On Dec. 9, 2015, 2:20 a.m.,

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2015-12-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review109479 --- Patch looks great! Reviews applied: [40224] Passed command:

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2015-12-08 Thread Jian Qiu
> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote: > > src/master/http.cpp, line 331 > > > > > > Seems miss credentials, whitelist These two flags returns as Path instead of protobuf. - Jian

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2015-12-08 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/ --- (Updated Dec. 9, 2015, 2:20 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2015-12-01 Thread Jian Qiu
> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote: > > I think keep the sync of these files when flags add or delete Protobuf > > fields a bit hard. Is it possible to change flags stringify protobuf > > objects as json string Thanks hasdent. I do not think we can overload or have a

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

2015-11-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review107604 --- I think keep the sync of these files when flags add or delete

Review Request 40224: Fix wrong flags infos in /state and /flags

2015-11-22 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/ --- Review request for mesos, Ben Mahler and haosdent huang. Bugs: MESOS-3792