Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 1:06 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-12-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review109652 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015, 1:06

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 12:08 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-11-17 Thread Alex Clemmer
> On Nov. 17, 2015, 9:11 p.m., Joseph Wu wrote: > > Since the Windows build was broken by this > > (https://reviews.apache.org/r/39005/), you may want to separate this commit > > from the chain. The reason I put it at the end is because I briefly thought that it would be unwise to get caught

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-11-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106937 --- Ship it! Since the Windows build was broken by this (https://revi

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-11-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review106851 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 3

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

2015-11-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Nov. 17, 2015, 10:59 a.m.) Review request for mesos, Artem Harutyunyan