Re: Review Request 40544: Added quota remove handling.

2015-12-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/ --- (Updated Dec. 21, 2015, 6:54 p.m.) Review request for mesos, Alexander

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review107995 --- 1. General fly by style comments. 2. Have we thought about moving

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108011 --- Please adjust the JIRA ticket: MESOS-4014. - Alexander Rukletsov

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108086 --- src/master/quota_handler.cpp (lines 372 - 386)

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review108069 --- Ship it! Minor nits, and addressed comments before committing. -

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/ --- (Updated Nov. 25, 2015, 9:26 p.m.) Review request for mesos, Alexander

Re: Review Request 40544: Added quota remove handling.

2015-11-25 Thread Joris Van Remoortere
> On Nov. 23, 2015, 8:43 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 387 > > > > > > I think we need to check if the role is known by master just like what > > we did for set quota, and also need

Re: Review Request 40544: Added quota remove handling.

2015-11-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/#review107565 --- src/master/quota_handler.cpp (line 387)

Re: Review Request 40544: Added quota remove handling.

2015-11-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/ --- (Updated Nov. 22, 2015, 1:35 p.m.) Review request for mesos, Alexander