Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-13 Thread Neil Conway
> On Jan. 12, 2016, 10:56 p.m., Adam B wrote: > > src/tests/executor_http_api_tests.cpp, line 394 > > > > > > Do you think there's any test overhead in doing another AWAIT for a > > `response` that has already been

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114322 --- Patch looks great! Reviews applied: [41806] Passed command:

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114148 --- Patch looks great! Reviews applied: [41806] Passed command:

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/ --- (Updated Jan. 12, 2016, 8:47 p.m.) Review request for mesos and Adam B.

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114086 --- Thanks for cleaning this up. I've got a question about the

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2015-12-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review112350 --- Patch looks great! Reviews applied: [41806] Passed command:

Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2015-12-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/ --- Review request for mesos and Adam B. Repository: mesos Description ---