Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- (Updated Jan. 15, 2016, 6:36 a.m.) Review request for mesos and Benjamin

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/#review114401 --- Ship it! LGTM, but see issues on documentation and comments

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/#review113033 ---

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Michael Park
> On Jan. 6, 2016, 9:51 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp, line 66 > > > > > > Seems like an `explicit` ctr is good enough here, right? Otherwise

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Michael Park
> On Jan. 6, 2016, 9:51 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp, line 67 > > > > > > Any reason you did not delete the ctr from `T&&`? Used

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- (Updated Jan. 6, 2016, 10 p.m.) Review request for mesos and Benjamin Hindman.

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- (Updated Jan. 6, 2016, 2:48 a.m.) Review request for mesos and Benjamin

Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41946/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description