Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115547 --- Patch looks great! Reviews applied: [42235, 41961, 42236, 42237,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115586 --- Ship it! Ship It! - Timothy Chen On Jan. 21, 2016, 12:41 a.m.,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115446 --- Ship it! Ship It! - Gilbert Song On Jan. 18, 2016, 12:14 a.m.,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Jie Yu
> On Jan. 18, 2016, 11:02 p.m., Timothy Chen wrote: > > src/tests/uri_fetcher_tests.cpp, line 216 > > > > > > Should we create a constant for docker registry server url? We're > > referring to it in multiple places

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 21, 2016, 12:41 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 18, 2016, 8:14 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review114974 --- Patch looks great! Reviews applied: [42235, 41961, 42236, 42237,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115074 --- src/tests/uri_fetcher_tests.cpp (line 216)

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 18, 2016, 6:54 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 17, 2016, 9:53 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 13, 2016, 11:29 p.m.) Review request for mesos, Ben Mahler,

Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy