Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Avinash sridharan
> On Feb. 3, 2016, 7:50 a.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 58 > > > > > > We generally leave a line before the comment and the TODO to correctly > >

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 3, 2016, 9:11 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117632 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117655 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117588 --- Primarily fly-by style comments.

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 3, 2016, 6:46 a.m.) Review request for mesos and Jie Yu.