Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117118 --- Fix it, then Ship it! Thanks for taking this on Neil! As we

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, 10:20 p.m.) Review request for mesos and Joris Van

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-30 Thread Neil Conway
> On Jan. 30, 2016, 9:53 p.m., Joris Van Remoortere wrote: > > src/tests/group_tests.cpp, lines 451-452 > > > > > > Maybe a comment explaining that we're triggering the timeout? Or is > > this too self-explanatory?

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117130 --- Patch looks great! Reviews applied: [42987, 42988] Passed

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, midnight) Review request for mesos and Joris Van

Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4546

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 29, 2016, 11:57 p.m.) Review request for mesos and Joris Van

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, 1:16 a.m.) Review request for mesos and Joris Van

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117093 --- Patch looks great! Reviews applied: [42987, 42988] Passed