Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review120619 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 24, 2016,

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Feb. 24, 2016, 11:41 p.m.) Review request for mesos and Joris Van

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Neil Conway
> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote: > > src/tests/group_tests.cpp, line 492 > > > > > > Do you mean `Ensure that no pending messages are delivered.`? > > Or `if any`, then what? i.e., we

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Feb. 16, 2016, 5:59 p.m.) Review request for mesos and Joris Van

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review119309 --- src/tests/group_tests.cpp (lines 450 - 454)

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Feb. 1, 2016, 9:40 p.m.) Review request for mesos and Joris Van

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review117304 --- Patch looks great! Reviews applied: [43033, 43065, 43034, 43035]

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-01-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/#review117153 --- Bad patch! Reviews applied: [43033, 43034] Failed command:

Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-01-31 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43035/ --- (Updated Jan. 31, 2016, 8:04 p.m.) Review request for mesos and Joris Van