Re: Review Request 43201: Updated reservation documentation.

2016-02-11 Thread Greg Mann
> On Feb. 11, 2016, 2:59 a.m., Guangya Liu wrote: > > docs/reservation.md, lines 61-63 > > > > > > What about putting NOTE to a new line? > > > > > NOTE: As of 0.27.0, these endpoints cannot be used when

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Guangya Liu
> On 二月 11, 2016, 2:59 a.m., Guangya Liu wrote: > > docs/reservation.md, lines 61-63 > > > > > > What about putting NOTE to a new line? > > > > > NOTE: As of 0.27.0, these endpoints cannot be used when HTTP

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118830 --- Patch looks great! Reviews applied: [43199, 43200, 43201]

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann
> On Feb. 11, 2016, 2:59 a.m., Guangya Liu wrote: > > docs/reservation.md, lines 61-63 > > > > > > What about putting NOTE to a new line? > > > > > NOTE: As of 0.27.0, these endpoints cannot be used when

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118806 --- Fix it, then Ship it! docs/reservation.md (lines 61 - 63)

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/ --- (Updated Feb. 11, 2016, 1:39 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann
> On Feb. 10, 2016, 7:38 a.m., Adam B wrote: > > docs/reservation.md, lines 56-57 > > > > > > How about: "Each framework may only reserve resources for its own role." Changed. - Greg

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/ --- (Updated Feb. 9, 2016, 7:32 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118497 --- Patch looks great! Reviews applied: [43199, 43200, 43201]

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118609 --- Fix it, then Ship it! docs/reservation.md (lines 56 - 57)

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118608 --- docs/reservation.md (line 62)

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118352 --- Patch looks great! Reviews applied: [43201] Passed command:

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118328 --- Fix it, then Ship it! docs/reservation.md (line 44)

Review Request 43201: Updated reservation documentation.

2016-02-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/ --- Review request for mesos, Neil Conway and Vinod Kone. Bugs: MESOS-4452