Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121598 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121596 --- Ship it! I'm voting ship it, but I do want to call out that I

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 6:15 a.m.) Review request for mesos, Artem

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121561 --- 3rdparty/CMakeLists.txt (line 30)

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121560 --- Ship it! - Alex Clemmer On March 2, 2016, 12:52 a.m., Diana

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 12:52 a.m.) Review request for mesos, Artem

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 7:42 p.m.) Review request for mesos, Artem

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 25, 2016, 8:22 a.m.) Review request for mesos, Artem

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120510 --- Bad patch! Reviews applied: [43889] Failed command:

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote: > > 3rdparty/libprocess/cmake/macros/External.cmake, line 38 > > > > > > And why we need change `EXTERNAL` macro here? I prososal add a version > > to our

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated Feb. 24, 2016, 2:05 p.m.) Review request for mesos, Artem

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120386 --- Bad patch! Reviews applied: [43889] Failed command:

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120349 --- Hi, I think the bug field for this review should be `MESOS-4746`?

Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van