Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/#review121966 --- Ship it! Ship It! - Vinod Kone On March 4, 2016, 12:03

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- (Updated March 4, 2016, 12:03 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- (Updated March 3, 2016, 1:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-02 Thread Anand Mazumdar
> On March 2, 2016, 11:59 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 463 > > > > > > don't you need to guard this with !running.load() check? To be more precise, I moved all the `running.load()`

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/#review121747 --- include/mesos/v1/scheduler.hpp (line 86)

Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4029