Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-21 Thread Zhiwei Chen
> On March 22, 2016, 7:21 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 175-177 > > > > > > Why do we need this now? In http-parse >= 2.x, the url.fragement is None, the previous code did

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124679 --- Can you also explain the testing you have done?

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-06 Thread Zhiwei Chen
> On March 4, 2016, 3:37 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 44 > > > > > > How about align the `` here. > > Zhiwei Chen wrote: > There are too many backslashes that

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122075 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-04 Thread haosdent huang
> On March 4, 2016, 7:37 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 44 > > > > > > How about align the `` here. > > Zhiwei Chen wrote: > There are too many backslashes that

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-04 Thread Zhiwei Chen
> On March 4, 2016, 3:37 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > > > > > ditto. In the real file, there is a table bracket and backslash. > On March 4, 2016, 3:37

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122029 --- 3rdparty/libprocess/3rdparty/Makefile.am (line 44)

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 4, 2016, 3:24 p.m.) Review request for mesos, Ben Mahler, Alex

Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- Review request for mesos, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: