Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-04-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review127727 --- Ship it! Ship It! - Ben Mahler On April 2, 2016, 8:07 a.m.,

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-04-02 Thread haosdent huang
> On March 21, 2016, 6:07 p.m., Kevin Klues wrote: > > Ship It! Thank you very much for your review. @adam-mesos, @bmahler, may I have your reviews? Thank you in advance. - haosdent --- This is an automatically generated e-mail. To

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-04-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- (Updated April 2, 2016, 8:07 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-21 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review124608 --- Ship it! Ship It! - Kevin Klues On March 16, 2016, 1:50

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review123847 --- Patch looks great! Reviews applied: [44832] Passed command:

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- (Updated March 16, 2016, 1:50 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review123792 --- src/common/parse.hpp (lines 107 - 113)

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review123624 --- Patch looks great! Reviews applied: [44832] Passed command:

Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

2016-03-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- Review request for mesos, Adam B, Ben Mahler, and Kevin Klues. Bugs: