Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Zhiwei Chen
> On March 31, 2016, 2:10 a.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Vinod Kone
> On March 30, 2016, 6:10 p.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126160 --- This could break existing clients which include extra whitespace,

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126158 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 5:35

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126065 --- Patch looks great! Reviews applied: [45471] Passed command:

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:33 p.m.) Review request for mesos, Greg Mann and

Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-4805