Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review130021 --- why not group it into `namespace linux`, along with others in the

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread haosdent huang
> On April 21, 2016, 5:45 p.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 37 > > > > > > I think need remove this blank line. > > Deshi Xiao wrote: > are u sure? > > 36 using

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-21 Thread Deshi Xiao
> On 四月 21, 2016, 5:45 p.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 37 > > > > > > I think need remove this blank line. are u sure? 36 using fs::FileSystemTable;

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-13 Thread Deshi Xiao
> On 四月 6, 2016, 9:04 p.m., Neil Conway wrote: > > src/tests/containerizer/fs_tests.cpp, line 35 > > > > > > Not yours, but we should sort these alphabetically. @Neil Conway how aobut your feedback. - Deshi

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review128396 --- Patch looks great! Reviews applied: [45500] Passed command:

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 12, 2016, 11:49 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review128365 --- Bad patch! Reviews applied: [45500] Failed command:

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-12 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 12, 2016, 9:33 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review128096 --- Bad patch! Reviews applied: [45500] Failed command:

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 11, 2016, 7:23 a.m.) Review request for mesos, haosdent huang and