Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-23 Thread Qian Zhang
> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are t

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-14 Thread Anand Mazumdar
> On April 12, 2016, 9:11 p.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are t

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-14 Thread Vinod Kone
Anand might have ideas. If we can get its os pid we could do kill on it? @vinodkone > On Apr 14, 2016, at 8:21 AM, Qian Zhang wrote: > > > >>> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: >>> Are you also planning to update slave recovery tests? Those are the most >>> crucial. >> >> Qian

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-14 Thread Qian Zhang
> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are t

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review128787 --- Ship it! Ship It! - Vinod Kone On April 13, 2016, 9:15 a.m.,

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Vinod Kone
> On April 12, 2016, 9:11 p.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are t

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. Sure, I will update slave recovery tests soon. Just want to double confirm, in `slave_recovery_tests.cpp`, I see there are two TODOs related to HTTP based

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review128658 --- Bad patch! Reviews applied: [45670, 44427, 44424, 44423] Failed

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- (Updated April 13, 2016, 5:15 p.m.) Review request for mesos, Anand Mazumdar an